[SC-23705] fix(sematext): deduplicate corrupted measurement name prefixes #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ixes Fix Apache metrics corruption where field names contained 64+ repeated "apache." prefixes (e.g., "apache.apache.apache...bytespersec"). The root cause: when originalName arrives corrupted, the lookup key becomes "apache.apache.apache.BusyWorkers" which doesn't match fieldReplaces["apache.BusyWorkers"], falling back to ChangeNames() which preserves the corruption. The fix adds deduplicatePrefix() to normalize measurement names before building lookup keys (e.g., "apache.apache.apache" → "apache").
Member
But why does it arrive corrupted? Where does it come from in this corrupt format? Isn't that what we should figure out and fix the problem at the source? |
Member
Author
Yes valid questions but I couldn't find the source so far. If I understand correctly it could be related to re-try logic but I'm not total sure. |
Member
Author
|
even with patch, still seeing weird names, will close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
deduplicatePrefix()function to normalize measurement names before building lookup keysTechnical Details
Root Cause
When
originalNamearrives corrupted (e.g.,"apache.apache.apache..."), the field lookup key atrename.go:220becomes:This doesn't match
fieldReplaces["apache.BusyWorkers"], so it falls back toChangeNames()which returns the corrupted name.Fix
The
deduplicatePrefix()function normalizes corrupted measurement names before building lookup keys:"apache.apache.apache"→"apache""nginx.nginx.nginx"→"nginx"This ensures the lookup key is always
"apache.BusyWorkers"which correctly maps to"workers.busy".Test Plan
deduplicatePrefix()covering normal inputs and edge cases